search

PurpleI2P / i2pd-tools

Some useful tools for I2P
BSD 3-Clause "New" or "Revised" License
119 stars 37 forks source link

Not using standard library headers #98

Closed BruhRain closed 5 months ago

BruhRain commented 5 months ago

In your file vain.cpp you seem to not use the format library. Well firstly, this is because you're compiling for C++17. is for C++20.

Secondly, why are you using boost, when in C++17, boosts filesystem library was implemented into the standard library. So was chrono, and date-time. the only acceptable boost library would be the program-options library.

It seems stupid to use third-party libraries when they're already implemented into the standard library, AND then also not using your brain to figure out that is C++20. if you had one look at cppreference std::format you would realise that it says "(C++20)"

It is available on all major compilers such as GCC, Clang and MSVC.

orignal commented 5 months ago

vain is not supported. Please don't create any tickets about it or it will be removed completely.

orignal commented 5 months ago

FYI, boost::filesystem is used by the main i2pd for C++11 support. No reason to rewrite it to std::filesystem just for C++17 especially it's not supported by any C++17, g++-7 for example.