PurpleI2P / i2pd

🛡 I2P: End-to-End encrypted and anonymous Internet
https://i2pd.website
BSD 3-Clause "New" or "Revised" License
3.14k stars 419 forks source link

miniupnp-2.2.8: call of UPNP_GetValidIGD changed #2071

Closed khumarahn closed 3 days ago

khumarahn commented 2 weeks ago

Hi!

In the recent version of miniupnp, UPNP_GetValidIGD requires two more arguments: char * wanaddr, int wanaddrlen.

The change happened here: https://github.com/miniupnp/miniupnp/commit/c0a50ce33e3b99ce8a96fd43049bb5b53ffac62f

Bug found here: https://bugs.gentoo.org/934058 (i2pd does not compile against miniupnp-2.2.8)

r4sas commented 1 week ago

Can you provide patch with if/else for preprocessor (using check against MINIUPNPC_API_VERSION)?

steils commented 1 week ago

https://github.com/PurpleI2P/i2pd/pull/2072