Error on payment link (iOS)

PurpleSoftSrl / sumup_flutter_plugin

A Flutter wrapper to use the SumUp SDK. With this plugin, your app can easily connect to a SumUp terminal, login and accept card payments on Android and iOS.

https://www.purplesoft.io

MIT License

17 stars 17 forks source link

Error on payment link (iOS) #30

Closed ghi8GPA closed 1 year ago

ghi8GPA commented 2 years ago

Hi, first of all I want to thank you so much for this plugin!

I found a bug when trying to pay through Payment link on iOS:

on payment link, as we are processing an online payment, card is empty, and so we need to add a null safe, otherwise the app crashes:
on payment link, checkoutResult.additionalInfo?["installments"] is returned, but its type is string and so on dart side the code breaks (SumupPluginCheckoutResponse.dart):

I have not yet tried the functionality on Android devices.

Thanks!

ghi8GPA commented 2 years ago

For the second issue che correct fix is defaulting instalments to an integer instead of an empty string (line 95 of SwiftSumupPlugin)

sstasi95 commented 1 year ago

Hi,

Thank you for finding the issues and the solutions. Unfortunately at the moment I'm unable to test them because our SumUp terminal is broken and we're waiting for the replacement.

I'll be back here as soon as I'm able to debug the issues, hopefully in a few weeks.

mahmoudalaa97 commented 1 year ago

I have a question about the payment response did you change the amount from double to String in your new API, now I have the issue in my app production when I trace the scenario I found a change amount type

sstasi95 commented 1 year ago

@mahmoudalaa97 could you please open a new issue providing some details about the problem you are encountering?

sstasi95 commented 1 year ago

Hi @ghi8GPA,

In the latest SumUp iOS release, they dropped support for Payment Links. Here's the changelog.

So, I think we can close this issue.