PurpleTurtleCreative / completionist

Asana integration plugin for WordPress.
https://purpleturtlecreative.com/completionist/
GNU General Public License v3.0
1 stars 0 forks source link

Fix allowing multiple WordPress users to authenticate with the same Asana user GID #177

Closed MichelleBlanchette closed 1 year ago

MichelleBlanchette commented 1 year ago

This causes Completionist to err when determining which WordPress user corresponds to the Asana user GID. This was noted in the source code but has been overlooked:

https://github.com/PurpleTurtleCreative/completionist/blob/cc246d01668c82146984f371ba4cac0230b0852c/src/includes/class-asana-interface.php#L475-L479

I now ran into a user experiencing this issue per the given screenshot. Notice they're trying to set the assignee which is exposing the duplicate Asana user GID issue.

image

MichelleBlanchette commented 1 year ago

To resolve this, I need to notify Completionist users of any duplicate Asana GIDs (near their collaborators table) so they can disconnect the secondary accounts from Completionist. Also, users should not be allowed to connect Completionist with an Asana user GID that already exists on the WordPress site by another authenticated user.

MichelleBlanchette commented 1 year ago

The user came back saying that they actually prefer using one Asana user with multiple WordPress users. To me, it sounds like an agency is represented within their client's Asana as one identity, while the agency's team members are traced with their own WordPress user identities as they make revisions on the site.