PurpleTurtleCreative / completionist

Asana integration plugin for WordPress.
https://purpleturtlecreative.com/completionist/
GNU General Public License v3.0
1 stars 0 forks source link

Simplify the Options class and use WordPress's built-in sanitization and validation functions #188

Closed MichelleBlanchette closed 11 months ago

MichelleBlanchette commented 11 months ago

I opened a (now stale) branch a while ago where I briefly attempted progress into this, but it didn't feel worth it at the time: https://github.com/PurpleTurtleCreative/completionist/tree/simplify-options

Now, a lot of Plugin Review errors have come up related to the Options class—which is not a very readable class to begin with, despite being written in such a way to encourage simplicity. 🙃

I'd also like to remove the reflections class usage for uninstalling all options. The option constants are already hard-coded in the other functions, so might as well just do it there, too, for readability. There's already manual labor with adding new option constants to the class, anyways. 😒