search

PurpleTurtleCreative / completionist

Asana integration plugin for WordPress.
https://purpleturtlecreative.com/completionist/
GNU General Public License v3.0
1 stars 0 forks source link

Resolve PHP SDK notices for PHP 8.2 #217

Closed MichelleBlanchette closed 4 months ago

MichelleBlanchette commented 4 months ago

Apply patch file in the build script after composer dependencies are installed.

See https://github.com/Asana/php-asana/pull/119#issuecomment-2081032886 for a start on this.

There are #[\ReturnTypeWillChange] deprecation notices coming from vendor/nategood/httpful/src/Httpful/Response/Headers.php and #[\AllowDynamicProperties] coming from Asana's PHP SDK.

Eventually, we may need to switch to our own custom class implementation for working with the Asana API due to the lack of activity in the official PHP SDK.

MichelleBlanchette commented 4 months ago

~This has good information on how to generate and apply patches via Composer itself: https://tomasvotruba.com/blog/2020/07/02/how-to-patch-package-in-vendor-yet-allow-its-updates~

That didn't work. It said the patch files were invalid when trying to apply them on composer install. Also, that was still tedious and not ideal.

MichelleBlanchette commented 4 months ago

Should probably just fork https://github.com/Asana/php-asana and include it in the build pipeline with our own branch of fixes. Aye yi yi... So it'd be added as a git submodule that needs to be built rather than a simple composer dependency. Sigh...