search

PurpurMC / Purpur

Purpur is a drop-in replacement for Paper servers designed for configurability, and new fun and exciting gameplay features.
https://purpurmc.org
MIT License
2.01k stars 358 forks source link

Recognizing Purpur as a fork of Paper #5

Closed x1p closed 4 years ago

x1p commented 4 years ago

Describe the bug The plugin ChatControl seems not to recognize Purpur as a fork of Paper. This might apply to all plugins that give a message to promote Paper.

[15:40:59 INFO]: !-----------------------------------------------------!
[15:40:59 INFO]: **** Warning ****
[15:40:59 INFO]: Packet features for Minecraft 1.14 and newer
[15:40:59 INFO]: require PaperSpigot instead of Spigot.
[15:40:59 INFO]: Get it from: https://papermc.io
[15:40:59 INFO]: !-----------------------------------------------------!

I could inform all plugins that give this promoted message, or maybe Purpur could present itself as "paper".

To Reproduce Just run ChatControl (paid)

Screenshots or Videos If applicable, add screenshots or videos to help explain your problem.

Plugins ChatControl, ProtocolLib

Version [15:48:03 INFO]: This server is running Purpur version git-Purpur-299 (MC: 1.14.4) (Implementing API version 1.14.4-R0.1-SNAPSHOT) [15:48:03 INFO]: Checking version, please wait... [15:48:04 INFO]: Previous version: git-Paper-214 (MC: 1.14.4) [15:48:04 INFO]: You are running the latest version

Is bug present on Paper, Spigot, CraftBukkit, or Vanilla No, I think this is obvious

Additional context

BillyGalbreath commented 4 years ago

Link me to ChatControl's source code and I'll have a look.

x1p commented 4 years ago

It's not open source. It's a premium plugin. Github: https://github.com/kangarko/ChatControl-Pro

BillyGalbreath commented 4 years ago

Then there's literally nothing I can do. Talk to the developer of ChatControl and tell them to do feature checks correctly.

He should be checking if certain classes/methods exist before using them, not if the server implementation reports as "paper"

I will not have purpur falsely report as "paper"

BillyGalbreath commented 4 years ago

See this old Reddit thread for why falsely identifying as the upstream implementation is a bad idea and why I won't do it. (Spigot still to this day identifies as CraftBukkit and it still causes issues)

https://www.reddit.com/r/admincraft/comments/1lgcpx/tagapi_prints_stack_trace_to_spigot_users_fooling/

Imagine if Paper identified as Spigot or CraftBukkit :S

x1p commented 4 years ago

No problem :+1: