search

PurpurMC / PurpurClient

Fixes client-side vanilla bugs
https://modrinth.com/mod/purpurclient/
MIT License
53 stars 17 forks source link

Bundled Guava causes crash with FerriteCore #29

Closed malte0811 closed 1 year ago

malte0811 commented 1 year ago

You are currently bundling Guava in your mod jar, the exact same version already supplied by MC. In FerriteCore I define new classes in a Guava package using MethodHandles.Lookup#defineClass. For some reason this silently fails when Guava is loaded from a jar-in-jar source on Quilt, see malte0811/FerriteCore#115 (this might be a bug in Quilt). It should be safe for you to stop bundling Guava since MC already supplies it, in my testing that worked and fixed the crash.

encode42 commented 1 year ago

Unfortunately, it is not safe for Guava to not be shaded. Configurate's HOCON library, for some reason, is having dependency issues without it. I'm personally not a client modder, nor do I have experience with Configurate, so I'm not sure how to debug the issue further. However, it was planned to drop Configurate entirely anyways.

malte0811 commented 1 year ago

It looks like it's fixed in newer Quilt builds (apparently there were other issues in weird classloading situations), so disregard this.