it might conflict with the other pack that touches the infinity enchantment because effects is defined here - no idea if all of the extra stuff is necessary and I did not perform adequate testing
supported_items apparently only accepts the actual items, not tags like you have in your other pack i just mentioned (I didn't test the other pack so I can't say for sure though - when trying to use a generator I encountered an error but the preset used the tag, but then when actually taking the time to test things a tag would not work at all).
few things to note with this pr;
I hope this is a bit useful