search

PurpurMC / PurpurPacks

Purpur suggestions that should be a datapack
https://modrinth.com/organization/purpurmc/datapacks
MIT License
17 stars 2 forks source link

kindof fix infinity on crossbow #9

Closed CyberFlameGO closed 4 months ago

CyberFlameGO commented 4 months ago

few things to note with this pr;

  1. it might conflict with the other pack that touches the infinity enchantment because effects is defined here - no idea if all of the extra stuff is necessary and I did not perform adequate testing
  2. supported_items apparently only accepts the actual items, not tags like you have in your other pack i just mentioned (I didn't test the other pack so I can't say for sure though - when trying to use a generator I encountered an error but the preset used the tag, but then when actually taking the time to test things a tag would not work at all).
  3. pack only works when unzipped - no idea why

I hope this is a bit useful

RhythmicSys commented 4 months ago

Thank you, I guess I copied the mending/infinity pack and didn't edit it after that oops