Closed colinfruit closed 6 years ago
thanks, I can add these two improvements if you want. 👍
Sure that'd be great
@colinfruit Also: if key === 'Escape'
, stop editing and reset newTitle
to ''
Sure
(I know I didn't mention that before, but I just realized that letting users stop editing would be useful. Could even set showInput: false
onBlur... not sure.)
Yes, no problem.
For onBlur() let's just return to original?
Yup, perfect.
Changes committed, thanks a lot for the help
Merged! Great work, @colinfruit :tada: :tada: :tada:
@colinfruit Looks great! Well done :+1: about to pull and double-check, but the code is simple and clean.