search

PursuanceProject / pursuance

Pursuance: end-to-end encrypted task management optimized for large numbers of volunteers. We are building a vast and formidable ecosystem of opposition to institutionalized injustice.
https://pursuanceproject.org/
Other
133 stars 15 forks source link

add title editing functionality #191

Closed colinfruit closed 6 years ago

elimisteve commented 6 years ago

@colinfruit Looks great! Well done :+1: about to pull and double-check, but the code is simple and clean.

colinfruit commented 6 years ago

thanks, I can add these two improvements if you want. 👍

elimisteve commented 6 years ago

Sure that'd be great

elimisteve commented 6 years ago

@colinfruit Also: if key === 'Escape', stop editing and reset newTitle to ''

colinfruit commented 6 years ago

Sure

elimisteve commented 6 years ago

(I know I didn't mention that before, but I just realized that letting users stop editing would be useful. Could even set showInput: false onBlur... not sure.)

colinfruit commented 6 years ago

Yes, no problem.

colinfruit commented 6 years ago

For onBlur() let's just return to original?

elimisteve commented 6 years ago

Yup, perfect.

colinfruit commented 6 years ago

Changes committed, thanks a lot for the help

elimisteve commented 6 years ago

Merged! Great work, @colinfruit :tada: :tada: :tada: