search

PursuanceProject / pursuance

Pursuance: end-to-end encrypted task management optimized for large numbers of volunteers. We are building a vast and formidable ecosystem of opposition to institutionalized injustice.
https://pursuanceproject.org/
Other
133 stars 15 forks source link

I 134 ui should go nuts when a user completes a task #231

Open 4xdk opened 6 years ago

4xdk commented 6 years ago

Totally not sure if this is the right way (local component state) but seems to me like dispatching actions for this would overcomplicate things(?).

4xdk commented 6 years ago

The only slight issue is that when sidebar is open, BOTH TaskStatus elements show confetti. This is actually not visible (unless you hack the dom/css with dev tools to move the sidebar), just FYI.

elimisteve commented 6 years ago

@4xdk Are you saying that half the confetti is thrown behind the right panel, so to speak?

4xdk commented 6 years ago

@elimisteve Yeah. There's double the amount to begin with, so end visual effect is the same.

There could be some additional wizardry we could do to prevent showing on both (like checking if sidebar is open maybe ?) Just not sure if it's worth it, since we can't really see the problem.

elimisteve commented 6 years ago

Yeah let's not worry about it right now, but good point; I'll keep this in mind :+1: .

On Sun, Jul 29, 2018 at 11:28 PM, 4xdk notifications@github.com wrote:

@elimisteve https://github.com/elimisteve Yeah. There's double the amount to begin with, so end visual effect is the same. There could be some additional wizardry we could do to prevent showing on both (like checking if sidebar is open maybe ?) Just not sure if it's worth it, since we can't really see the problem.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PursuanceProject/pursuance/pull/231#issuecomment-408760137, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIhU9Gg6Nr_UiMiKvV02bTlx5sJCITNks5uLqeegaJpZM4Vk9XD .