search

Purus / launch_review

A Flutter plugin to assist in leaving user reviews/ratings in the Google Play Store. Supports both Android and iOS.
https://pub.dartlang.org/packages/launch_review
MIT License
178 stars 117 forks source link

AppStore won't open if no App Id is provided #22

Open Abdelalim-dev opened 4 years ago

Abdelalim-dev commented 4 years ago

If no arguments are provided, it will consider the current package.

This part didn't work on iOS. I had to set the App Id of my application for it to open the AppStore page. My test was made on an iPhone 6 with iOS 12

pythoneer commented 4 years ago

I can confirm this. Looks like the code that is trying to get the appStoreId by itself is failing and does not expect the way it fails, thus not returning any error to the user (programmer).

this code passage is trying to fetch values by requesting this endpoint http://itunes.apple.com/lookup?bundleId=<bundle identifier>. I have tested it myself manually and it looks like this endpoint is not returning the correct or needed information anymore. This is what i am getting back for my specific bundle indentifier


{
 "resultCount":0,
 "results": []
}

This is maybe related to the fact that apple is shutting down itunes (or already has)? https://support.apple.com/en-qa/HT210200

Manually providing the id is working though.

Purus commented 4 years ago

Please let me know if someone can help with a PR. I can neither update nor test as I don't have any apple device.

On Mon, 25 May, 2020, 11:00 AM Dustin Bensing, notifications@github.com wrote:

I can confirm this. Looks like the code that is trying to get the appStoreId by itself is failing and does not expect the way it fails, thus not returning any error to the user (programmer).

this code passage https://github.com/Purus/launch_review/blob/master/ios/Classes/LaunchReviewPlugin.m#L64 is trying to fetch values by requesting this endpoint http://itunes.apple.com/lookup?bundleId=. I have tested it myself manually and it looks like this endpoint is not returning the correct or needed information anymore. This is what i am getting back for my specific bundle indentifier

{ "resultCount":0, "results": [] }

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Purus/launch_review/issues/22#issuecomment-633384029, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIHDZ4IE5E4JTKJHQIERV3RTH7BDANCNFSM4NHNEUMA .

pythoneer commented 4 years ago

I can help with a PR and Testing on actual devices. I have no clue how to regain the functionality, because the original (itunes) service is seemingly dead. Idk if there is any other way to get the information from.

Purus commented 3 years ago

Unfortunately, I can't test or fix this as I don't Mac machine.

SachinTanpure commented 3 years ago

It's April 2021. Any solution for this. I am facing this issue.

Purus commented 3 years ago

Please feel free to open a PR with the required changes. I can't do as I don't have a Mac.

On Wed, 7 Apr, 2021, 8:32 pm SachinTanpure, @.***> wrote:

It's April 2021. Any solution for this. I am facing this issue.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Purus/launch_review/issues/22#issuecomment-814987568, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIHDZ4B2XE6I43TX64HP6DTHRXXJANCNFSM4NHNEUMA .

pythoneer commented 3 years ago

The primary Problem is not "having a Macintosh PC or not". The primary Problem is gathering the needed information that is equivalent to the information that was previously provided by the itunes service that was shut down by apple.

vytautas-pranskunas- commented 2 years ago

any updates?

nicolasvahidzein commented 2 years ago

How can I help, i have a mac and iphones?