Purus / launch_review

A Flutter plugin to assist in leaving user reviews/ratings in the Google Play Store. Supports both Android and iOS.
https://pub.dartlang.org/packages/launch_review
MIT License
178 stars 117 forks source link

3.0.0 version not working in both Android and IOS #29

Closed venkata-reddy-dev closed 3 years ago

venkata-reddy-dev commented 3 years ago

Android error log Screenshot 2021-03-08 at 5 39 46 AM

Ios error log Screenshot 2021-03-08 at 5 35 16 AM

Android gradle build error log Screenshot 2021-03-08 at 5 38 44 AM

Note : Screenshot 2021-03-08 at 5 40 45 AM

1) Not working when i am using version 3.0.0 2) Working as expected when i am pointing to git url

fzyzcjy commented 3 years ago

is the example app run sucessfully?

venkata-reddy-dev commented 3 years ago

@fzyzcjy issue reproduced in example project

please see line no : 19 replaced path with latest version and error log in console

Screenshot 2021-03-08 at 7 25 38 AM

Note : I am thinking there may be something went wrong in release process

fzyzcjy commented 3 years ago

Hmm my null-safety migration seems to be unrelated with this.

Maybe caused by this merge? https://github.com/Purus/launch_review/commit/11c9dcdbe1ad89a84437f228b7f6e027ef7a691f

@Purus

nohli commented 3 years ago

Could you try? It should fix it :)

  launch_review:
    git:
      url: https://github.com/nohli/launch_review
      ref: fix-flutter-2
venkata-reddy-dev commented 3 years ago

@nohli i could test it when it is available in pub.dev along with your changes. because when i am pointing to git repo as dependency i am not facing any issues

cc: @Purus , @fzyzcjy

nohli commented 3 years ago

Edit: the new version has a fix.

@RR-Reddy so maybe the issue is not in this code...

I just downloaded the pub.dev version and there were 84 changed files compared to this repo's master.

For example (red is this repo, green the pub.dev version):

1

Maybe the added 'platforms' part is wrong.

fzyzcjy commented 3 years ago

@RR-Reddy So does 3.0.1 work for you?

venkata-reddy-dev commented 3 years ago

@fzyzcjy

Working fine.

i have tested in both Android and IOS just now.

Thanks to all for fixing this issue.