Fixed iOS crash. Added write review option. Cleaned up code.

Purus / launch_review

A Flutter plugin to assist in leaving user reviews/ratings in the Google Play Store. Supports both Android and iOS.

https://pub.dartlang.org/packages/launch_review

MIT License

180 stars 122 forks source link

Fixed iOS crash. Added write review option. Cleaned up code. #5

Closed KaYBlitZ closed 5 years ago

KaYBlitZ commented 5 years ago

Fixed iOS crash. Added write review option in method call. Currently defaults to showing write review window in the app store. When write review is set to false, the app store page will be shown, but not the write review prompt.

Cleaned up Android code. In the rare case that the Play store is not installed, the web browser will open instead.

Cleaned up dart code.

KaYBlitZ commented 5 years ago

This fixes issues 3 and 4. IOS won't crash but will throw an error if ios app id is not provided. IOS app id is REQUIRED to work.

Purus commented 5 years ago

I have merged the PR. I don't have an Mac so I haven't tried this ever. Thanks for your time on this.

KaYBlitZ commented 5 years ago

Great. Thank you. It might be a good idea to update the docs to state that iOS app id is required on the iOS side to work. Also, bumping the package version to state the new changes.

Purus commented 5 years ago

Sure..I will be doing it. Currently i am out of City. Will do when i am back.

Thanks,

Purusothaman Ramanujam

On Thu, Jan 10, 2019, 9:22 PM Kenneth Liang <notifications@github.com wrote:

Great. Thank you. It might be a good idea to update the docs to state that iOS app id is required on the iOS side to work. Also, bumping the package version to state the new changes.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Purus/launch_review/pull/5#issuecomment-453145376, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBx5-bVts1Mys5PqDT7MKVUwX_QvETMks5vB2GxgaJpZM4Zlsgn .