added namespace property for gradle 8 compatibility

Purus / launch_review

A Flutter plugin to assist in leaving user reviews/ratings in the Google Play Store. Supports both Android and iOS.

https://pub.dartlang.org/packages/launch_review

MIT License

178 stars 117 forks source link

added namespace property for gradle 8 compatibility #57

Closed sybrands-place closed 6 months ago

sybrands-place commented 8 months ago

Getting this issue when upgrading to gradle 8 for my project (Android) ` A problem occurred configuring project ':launch_review'.

Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl. Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

ndusart commented 7 months ago

Better to add this namespace if available to support older AGP:

    // Conditional for compatibility with AGP <4.2.
    if (project.android.hasProperty("namespace")) {
        namespace 'com.iyaffle.launchreview'
    }

sybrands-place commented 7 months ago

updated

Purus commented 6 months ago

Apologies. Sine the package has gone out of control and due to personal commitments, could not carry on with Flutter ecosystem development. I have marked the package as depreciated in the pub.dev page.