Purus / launch_review

A Flutter plugin to assist in leaving user reviews/ratings in the Google Play Store. Supports both Android and iOS.
https://pub.dartlang.org/packages/launch_review
MIT License
180 stars 122 forks source link

Doesn't work on iOS #6

Closed mulderpf closed 5 years ago

mulderpf commented 5 years ago

My app is on the Apple Store. Using the default parameters (e.g. none supplied), this definitely doesn't work. This has simply changed my "Rate on app store" link to an "Exit the app" link. It doesn't seem to crash either, but I can't be sure.

This was observed on a real Apple iPhone X.

I will update the app and send the actual app ID and try again.

In looking at the iOS code (Android developer here), it very much looks like there is some bad hard-coding going on:

e.g. itms-apps://itunes.apple.com/xy/app/foo/id%@?action=write-review and itms-apps://itunes.apple.com/WebObjects/MZStore.woa/wa/viewContentsUserReviews?type=Purple+Software&id=%@&action=write-review

KaYBlitZ commented 5 years ago

You can try my fork. I fixed many issues. I opened a PR but it hasn't been looked at yet. In pubspec.yaml use

launch_review:
    git: git://github.com/KaYBlitZ/launch_review.git

For iOS you have to include the app ID.

Purus commented 5 years ago

Thanks for your time on the PR. I will merge it today.

Thanks,

Purusothaman Ramanujam

On Wed, Jan 9, 2019, 1:00 AM Kenneth Liang <notifications@github.com wrote:

You can try my fork. I fixed many issues. I opened a PR but it hasn't been looked at yet. In pubspec.yaml use

launch_review: git: git://github.com/KaYBlitZ/launch_review.git

For iOS you have to include the app ID.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Purus/launch_review/issues/6#issuecomment-452422889, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBx54Tp_3o_2OYb8JRDFhL7lPyKzLqMks5vBPHagaJpZM4ZyUta .

Zazo032 commented 5 years ago

If this issue is solved in #5, as it's merged, this issue should be closed.

Purus commented 5 years ago

Thanks for the issue and creating the PR. It's now available as part of v2.0.0 package.

Feel free to create a new issue if you see any other issues.