search

Pushplaybang / knife

Nail vertical rhythm, modular scale, and REMs like a boss with this simple set of SASS/SCSS variables, functions and mixins.
http://pushplaybang.github.io/knife/
MIT License
67 stars 6 forks source link

libsass compatibility #5

Closed ronilaukkarinen closed 9 years ago

ronilaukkarinen commented 10 years ago

Hi,

I recently moved to libsass, because it's so much faster even in my largest projects. I get may only compare numbers when trying to compile knife and the line is this h1 { @include ktype(4, 2, 1); }.

Any ideas?

Edit: Probably related to my mixins again, but just wondering if there's libsass support available in the future or maybe I could help with that.

Pushplaybang commented 10 years ago

Hey Man

I've heard good things but haven't made the switch (despite doing a fair bit of node these days), mostly because I use susy for layout in all my projects, which I last time I checked threw a bit of a fit when confronted with libsass.

If you'd like to tackle libsass compatibility for knife that would be awesome, I'd super keen on any contributions or ideas.

Any Idea how libsass would limit us if at all?

whatsnewsisyphus commented 10 years ago

Fix included in https://github.com/Pushplaybang/knife/pull/8 , I think, otherwise it is your mixins messing it up and not libsass, but give it a try please @ronilaukkarinen

Pushplaybang commented 9 years ago

Closing as complete for now, if there is a reason to we can re open this issue. Thanks. Paul.