search

Pushplaybang / knife

Nail vertical rhythm, modular scale, and REMs like a boss with this simple set of SASS/SCSS variables, functions and mixins.
http://pushplaybang.github.io/knife/
MIT License
67 stars 6 forks source link

Add Shift Property to Ktype Mixin #7

Open Pushplaybang opened 9 years ago

Pushplaybang commented 9 years ago

as per the discussion in issue #2 and the discussion in this article on medium I would like to add a shift property to the ktype mixin to allow us to manually align typographic elements to the baseline appropriately, compensating for the discrepancies in type setting between setting type in photoshop and illustrator vs setting it on the web.

cibulka commented 9 years ago

+1!

Pushplaybang commented 9 years ago

I've done two experiments with this so far.

  1. one using padding and reducing the margin
    • this is cool because its compensating by adjusting the properties we're already manipulating
    • It makes it the functions / mixins more complex and more difficult to change in the future.
  2. Adjusting the relative top positioning.
    • very simple to implement
    • Keeps the margin and padding set.
    • I like this because it shifts the element independently and so any error as far less impact on other elements.

I'll play with these more and see if I can find more reasons to do it one way o r the other, or possibly look at making it optional with a preferred default but I'd love any input or ideas.

aficiomaquinas commented 6 years ago

+1