Pushwoosh / pushwoosh-appcelerator-titanium

Other
33 stars 16 forks source link

Open source the titanium modules #13

Closed hansemannn closed 8 years ago

hansemannn commented 8 years ago

Hey guys,

as a lot of people are currently moving from Parse to other services (like yours), the Titanium community is very interested in using your module in the future. To increase it's usage and the backup by the native module developer, I would welcome to see the module open sources.

Otherwise, I would just create a new module based on the iOS SDK, but working with the "original" one would be much nicer.

What are your thoughts on this? Thanks!

Hans

shaders commented 8 years ago

Hi,

I'm not sure I understand you. Do you want Pushwoosh module to be a part of Titanium SDK or something else? Though I like the idea of sharing the source of the module.

hansemannn commented 8 years ago

Not exactly. Currently, the module is available packaged with a closed source. Making it open-source would allow it other devs to extend the module by submitting a PR (like in other projects).

shaders commented 8 years ago

I see, just wondering if there is anything in particular you want to change/add to the module?

shaders commented 8 years ago

https://github.com/Pushwoosh/pushwoosh-appcelerator-titanium/tree/master/Module-Source Let me know your feedback.

hansemannn commented 8 years ago

Yes, thank you! There are some validation macros you could use to simplify the proxy validation. A lot of community users appreciate it to see the module open source. I will setup a PR over the weekend to propose something and you can check it if you want. Thanks!

shaders commented 8 years ago

Thanks! Looking forward to it.

shaders commented 8 years ago

@hansemannn hi, I wonder if you could help me with this ticket? Maybe you have any kind on information there?

https://github.com/Pushwoosh/pushwoosh-appcelerator-titanium/issues/19#issuecomment-204425484

hansemannn commented 8 years ago

Hey there, I only changed the iOS part of the module, Android remained the same.

shaders commented 8 years ago

I know, maybe you know what is the reason for the problem? It looks something confuses titanium internally.... maybe titanium itself.