search

Pushwoosh / pushwoosh-phonegap-plugin

Pushwoosh PhoneGap Build Plugin
Other
110 stars 139 forks source link

Fix issue 149 with [INSTALL_FAILED_CONFLICTING_PROVIDER] #157

Closed victorb closed 8 years ago

victorb commented 8 years ago

So, the proposed fix in https://github.com/Pushwoosh/pushwoosh-phonegap-plugin/issues/149 is not really the right way of fixing this. Writing stuff in the gradle.build gets overwritten later because the file is generated.

I came across this issue and made a post in the Google Groups for Phonegap ( https://groups.google.com/forum/#!topic/phonegap/bIef9FU1RJY ) and got pointed to a fixed issue in the PluginPush ( https://github.com/phonegap/phonegap-plugin-push/commit/15b76632ac2849f1cb2f48e75a5292dfaa97de7f )

This PR does the same fix here, so people don't have to edit unedited files.

Also, this would make your documentation better by removing this warning:

screen shot 2016-02-08 at 16 02 33
axemclion commented 8 years ago

Looks like this is fixed in CB-10014 and a corresponding commit.

We could get do away with this commit. To ensure that the plugin works with versions where this is fixed in Cordova, we could leverage Cordova's plugin pinning.

This commit is causing the plugins to be unusable with react-native-cordova-plugin. The fundamental issue is that ReactNative includes plugins as libraries, while Cordova simply changes build files to make plugins a part of the main project. A library cannot have an applicationID and thus, this library can only be used when included in a main project as a result of computing applicationID in gradle.

A library cannot really set an applicationID.