search

Pushwoosh / pushwoosh-phonegap-plugin

Pushwoosh PhoneGap Build Plugin
Other
110 stars 139 forks source link

Plugin adds Geolocation permission even though no Geolocation features are being used #159

Closed victorb closed 8 years ago

victorb commented 8 years ago

Hey!

Recently after updating the plugin, the application asks for permission to use the Geolocation features of the phone, even though we use no geolocation features from Pushwoosh or at all.

How can we work around this? The only way I can see is if we fork this repository and maintain our fork without any geolocation features but I would like to avoid this.

Any advice on this?

I left a note here https://github.com/Pushwoosh/pushwoosh-phonegap-plugin/commit/e194bd2dc0537c4b2a5e78b4ac9b92b0844319c5#commitcomment-16143334 and also wrote support but have yet to receive any response so opening this issue is my last try to contact you.

DimanAM commented 8 years ago

As a workaround you can remove these permissions from platforms/android/AndroidManifest.xml:

<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />

And build project using Android Studio.

victorb commented 8 years ago

@DimanAM Thanks for the proposed workaround, it's what we're currently doing. But we'd like to have a reproducible build and we're trying to not have the platforms/ directory in SCM.

But as a workaround it's valid, thanks.

arzanardi commented 8 years ago

@VictorBjelkholm I'm with you! We need this too.