search

Pushwoosh / pushwoosh-phonegap-plugin

Pushwoosh PhoneGap Build Plugin
Other
110 stars 139 forks source link

[Android] Remove setting applicationID as a dependency #176

Closed axemclion closed 8 years ago

axemclion commented 8 years ago

Pull Request #157 fixes the issue where applicationID is not set by the project.

Looks like this is fixed in CB-10014 and a corresponding commit.

We could get do away with this commit. To ensure that the plugin works with versions where this is fixed in Cordova, we could leverage Cordova's plugin pinning.

This commit is causing the plugins to be unusable with react-native-cordova-plugin. The fundamental issue is that ReactNative includes plugins as libraries, while Cordova simply changes build files to make plugins a part of the main project. A library cannot have an applicationID and thus, this library can only be used when included in a main project as a result of computing applicationID in gradle.

A library cannot really set an applicationID.

shaders commented 8 years ago

Pushwoosh plugin for react native will be published in a few days!