search

Pushwoosh / pushwoosh-phonegap-plugin

Pushwoosh PhoneGap Build Plugin
Other
110 stars 139 forks source link

Cannot build on android (Path must be a string. Received undefined) #313

Closed guirip closed 5 years ago

guirip commented 5 years ago

Hello

This issue is closely linked to this one I think: https://github.com/Pushwoosh/pushwoosh-phonegap-plugin/issues/297#issuecomment-418101837

config file undefined requested for changes not found at /work/mobile-spot/projects/testapp/platforms/android/undefined, ignoring Path must be a string. Received undefined

We had already encountered this kind of warning messages few month ago using pushwoosh-cordova-plugin, without consequence (like stated in above linked issue). Now that we need to customize AndroidManifest.xml using <edit-config> and <config-file> tags, the warning has became a blocking problem.

Simple steps to reproduce :

Now:

> cordova build
Android Studio project detected
config file undefined requested for changes not found at /work/projects/testapp/platforms/android/undefined, ignoring
Path must be a string. Received undefined
>

Once we add pushwoosh-cordova-plugin we cannot build our android app anymore.

edit 18/4/2019 Cordova version:

> cordova -v
8.1.2 (cordova-lib@8.1.1)
wfhm commented 5 years ago

@guirip

Just tried reproducing it following the steps you have described, and it indeed fails with cordova@8.1.2, however it works just fine with cordova@9.0.0. Could you please try upgrading Cordova CLI and let us know if the issue persists?

wfhm commented 5 years ago

@guirip did you have a chance to test it with the latest cordova version?

guirip commented 5 years ago

@wfhm

Thank you for your answer :) Maybe you could write somewhere in bold characters that Cordova 9 is mandatory.

Android Now the build process is OK, app runs well and we receive the pushes. :+1:

iOS We cannot build our app using Cordova 9 because it seems that some plugins does not support this cordova version, see: Using "requireCordovaModule" to load non-cordova module "q" is not supported :-1:

So now we have to uninstall/reinstall cordova depending on the target platform. This is pretty cumbersome. Is there any possibility that you produce a release compatible with Cordova 8 ?

wfhm commented 5 years ago

Hi @guirip,

Recently, we rolled out a new version of our plugin(7.15.0). Could you please try to use it and let me know about the result? It should work with Cordova 8+ for both platforms

https://github.com/Pushwoosh/pushwoosh-phonegap-plugin/releases/tag/7.15.0

wfhm commented 5 years ago

@guirip any news?

guirip commented 5 years ago

Hey I am sorry you have not received feedback on this one. I am not working for this company now but I transferred them your message as soon as I got your notification. It seems like no news is good news... All the best Cheers

Le jeu. 27 juin 2019 à 13:43, wfhm notifications@github.com a écrit :

Closed #313 https://github.com/Pushwoosh/pushwoosh-phonegap-plugin/issues/313.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Pushwoosh/pushwoosh-phonegap-plugin/issues/313?email_source=notifications&email_token=ABVB3B6P26WFCB72IOEEBQTP4SRXPA5CNFSM4HGWEQTKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSGWCQWY#event-2443978843, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVB3B257QIBQH7S634SH3DP4SRXPANCNFSM4HGWEQTA .

wfhm commented 5 years ago

@guirip Thank you for the update!