search

Pushwoosh / pushwoosh-xamarin

12 stars 18 forks source link

Removed an interface that is already bound in the Xamarin GMS packages #2

Closed Machinarius closed 8 years ago

Machinarius commented 8 years ago

I tried to compile my project against the official PW Xamarin.Android project and it failed with a duplicate LocationListenerImplementor binding error with the official Xamarin GMS package. This commit removes that java node so it's fixed.

shaders commented 8 years ago

Thanks!

Machinarius commented 8 years ago

No problem. Quite happy to be able to help.

I think the PR got an additional commit i did not intend to have merged into this repository as it is a breaking change, albeit a very small one. I renamed the CSProj files so the project names made more sense in my solution structure but that means everyone who submodules this repo (As i do with my fork) will suddenly have to rename their references.

You guys might want to consider rolling back that change as it might introduce build errors, specially with the samples.

I am sorry about that.