search

Pushwoosh / web-push-notifications

Web Push Notifications
Other
62 stars 28 forks source link

Unsubscribe error handling #35

Open finnan444 opened 1 week ago

finnan444 commented 1 week ago

Hello, maybe it will be better not to wrap unsubscribe method in try catch block? For example subscribe method is not wrapped and in my application i can detect when promise rejected and do some stuff (show try again later for user for example). But when i call unsubscribe promise is fulfilled but i see in console Error occurred during the unsubscribe.

enginseer-dev commented 1 week ago

Hello @finnan444, thank you for your feedback — please let us discuss it within the team and back to you.