search

Puxtril / Warframe-Exporter

Converts Warframe's custom file formats into standard formats
37 stars 0 forks source link

[Bug] Crash when trying to extract specific directory #38

Closed Whovian9369 closed 2 months ago

Whovian9369 commented 2 months ago

Trying to extract /EE/Editor/Darkitect/Materials/PBRCompliance/Shaders/ crashes the GUI version of the tool.

Specific file that it appears to be crashing on is /EE/Editor/Darkitect/Materials/PBRCompliance/Shaders/PBRComplianceArchitectural/2_p.hlsl, but can't confirm.

What I expected was for the files to be extracted or for an error to appear, but instead the whole tool crashes and closes.

Edit: This is from after the issue was closed, but I kept forgetting to add the log information here even though it gets cut off in the file.

...
[2024-09-21 22:34:49.968] [info] Extracting /EE/Editor/Darkitect/Materials/PBRCompliance/Shaders/PBRComplianceArchitectural/0_p.hlsl
[2024-09-21 22:34:49.968] [debug] Extracting as Shader, Enum=21
[2024-09-21 22:34:50.076] [info] Extracting /EE/Editor/Darkitect/Materials/PBRCompliance/Shaders/PBRComplianceArchitectural/1_p.hlsl
[2024-09-21 22:34:50.076] [debug] Extracting as Shader, Enum=21
[2024-09-21 22:34:50.101] [info] Extracting /EE/Editor/Darkitect/Materials/PBRCompliance/Shaders/PBRCompl
Puxtril commented 2 months ago

Can confirm extracting shaders from /EE/Editor/Darkitect/Materials/PBRCompliance/Shaders/ causes a segfault. Currently finishing up another feature, but ill look at this issue after.

Puxtril commented 2 months ago

This was due to hard-coding "ShaderPermutationDx11" in the shader extractor. I've made package loading more dynamic, which fixed the issue: f8a7b1d46733051c1804c30acc86f18bc28e2511