PuzzleTechHub / myus

A public hassle free puzzlehunt hosting tool
https://www.puzzlehuntmy.us/
MIT License
1 stars 9 forks source link

Inline image support #18

Open ebuntaran opened 4 months ago

ebuntaran commented 4 months ago

Support for inline images for puzzle content would be cool

betaveros commented 4 months ago

If you just want users to be able to embed images that they've uploaded elsewhere, you can allowlist the <img> tag by adding "img" to SAFE_TAGS in https://github.com/PuzzleTechHub/myus/blob/main/myus/myus/templatetags/markdown.py . I did not allowlist it for privacy/security reasons (by embedding an image from your own website you can get the IP of every viewer, etc.; maybe phishing becomes more plausible?), but those may not be dealbreakers and there are plenty of cool things you can do with them.

If you want users to upload images and inline them, I don't know the best way but it's probably moderately complicated/expensive.