Issue with building Prosjektportalen - sp-js-provisioning

Puzzlepart / prosjektportalen

Prosjektportal for SharePoint er et prosjektstyringsverktøy for SharePoint basert på prosjektveiviseren

Other

30 stars 16 forks source link

Issue with building Prosjektportalen - sp-js-provisioning #782

Closed tarjeieo closed 3 years ago

tarjeieo commented 3 years ago

Summary

There seems to be an issue with finding/using the correct version of sp-js-provisioning. This issue is the same for prosjektportalen-program. The one that is present in package.json now fails with message

npm ERR! Command failed: git checkout v0.8.9
npm ERR! error: pathspec 'v0.8.9' did not match any file(s) known to git

Tried various other variations of the import "sp-js-provisioning": "git+https://github.com/Puzzlepart/sp-js-provisioning.git", and "sp-js-provisioning": "1.1.0",

I managed to install packages with these two variations, but failed to build the project. Also experimented with different versions of node, but no luck.

Care to shed some light on what should be the correct setup for this @olemp ?

olemp commented 3 years ago

@tarjeieo Nothing has been changed for that repo as far I know.

okms commented 3 years ago

All tags had been pruned from https://github.com/Puzzlepart/sp-js-provisioning. I re-created v0.8.9 from commit 33d381d1b7bf112b69456c68607d47a83cc17de2. We could use head or a newer revision in the future. This should resolve the issue for everyone @tarjeieo. It builds using node 8 and 10 for me.

tarjeieo commented 3 years ago

Still fails at building with the following error

ERROR in [at-loader] ./node_modules/sp-js-provisioning/lib/schema.d.ts:1:10
    TS2305: Module '"../../@pnp/sp"' has no exported member 'CanvasColumnFactorType'.

olemp commented 3 years ago

All tags had been pruned from https://github.com/Puzzlepart/sp-js-provisioning. I re-created v0.8.9 from commit 33d381d1b7bf112b69456c68607d47a83cc17de2. We could use head or a newer revision in the future. This should resolve the issue for everyone @tarjeieo. It builds using node 8 and 10 for me.

All tags pruned? How?

okms commented 3 years ago

All tags had been pruned from https://github.com/Puzzlepart/sp-js-provisioning. I re-created v0.8.9 from commit 33d381d1b7bf112b69456c68607d47a83cc17de2. We could use head or a newer revision in the future. This should resolve the issue for everyone @tarjeieo. It builds using node 8 and 10 for me.

All tags pruned? How?

I do not know, however this is all the tags i can see

olemp commented 3 years ago

All tags had been pruned from https://github.com/Puzzlepart/sp-js-provisioning. I re-created v0.8.9 from commit 33d381d1b7bf112b69456c68607d47a83cc17de2. We could use head or a newer revision in the future. This should resolve the issue for everyone @tarjeieo. It builds using node 8 and 10 for me.

All tags pruned? How?

I do not know, however this is all the tags i can see

I have several tags locally.

Could try to repush them.

Did you create v0.8.9 from the latest commit?

olemp commented 3 years ago

Still fails at building with the following error

ERROR in [at-loader] ./node_modules/sp-js-provisioning/lib/schema.d.ts:1:10
    TS2305: Module '"../../@pnp/sp"' has no exported member 'CanvasColumnFactorType'.

I recreated the original v0.8.9 tag. Could you try again?

tarjeieo commented 3 years ago

Still fails at building with the following error
ERROR in [at-loader] ./node_modules/sp-js-provisioning/lib/schema.d.ts:1:10
    TS2305: Module '"../../@pnp/sp"' has no exported member 'CanvasColumnFactorType'.
I recreated the original v0.8.9 tag. Could you try again?

Works! 🎸 Thanks Ole&Ole