search

Puzzlepart / prosjektportalen365

Prosjektportalen for Microsoft 365
MIT License
29 stars 15 forks source link

Lag en PP footer som inneholder versjon og nyttige lenker #926

Closed olemp closed 1 year ago

olemp commented 1 year ago

Hard to avoid issues with this as long as we're stuffing it into the hub menu. I suggest creating a PP-specific footer instead. Might be other use cases for this as well down the line (e.g. "PP365 on GitHub", "Report an issue", "Suggest xyz").

image

Originally posted by @tarjeieo in https://github.com/Puzzlepart/prosjektportalen365/issues/902#issuecomment-1353592022

Remi749 commented 1 year ago

The "Hjelp tilgjengelig" button is also hidden if users use "Elements" plugin. Example:

image

The root element is hidden. image

Remi749 commented 1 year ago

Quick fix for this is to set a height for the "pp-help-content" div. This will put "? Help tilgjengelig" button on a line above the top navigation. This can also be done responsive if menu items clash with the button.

Do we really want to put this in a footer at the bottom? I think it will hide the help content feature too much and be overlooked.

I agree on all the other stuff that has been discussed that should go in a footer. @tarjeieo, thoughts?

Remi749 commented 1 year ago

Before: image

After: image

Remi749 commented 1 year ago

If customer has "Elements" plugin, it will look like this: image

With the quick fix it will not be hidden. But there will be some unnessecary whitespace for those that uses "Elements"

tarjeieo commented 1 year ago

Kindof agree with you, although I think a footer have merits in the long run. I suggest you open https://github.com/Puzzlepart/prosjektportalen365/issues/902 again and fix it by your quick fix - then we'll do a more thorough discussion on the footer later this year.