Pv3-Labs / gibberle

A gibberish guessing game.
https://gibberle.vercel.app
2 stars 0 forks source link

Feature/#57/navbar component #79

Closed DanielTran24 closed 3 weeks ago

DanielTran24 commented 3 weeks ago

About this PR

57

How to review

Ensure that the mobile and regular navbar appear with the navbar being at the top right and the heading beneath the navbar Check that this remains consistent across different pages

Checklist

  1. Scan your source code for useless code, comments, etc.

  2. Assess whether methods and classes follow single use/responsibility.

  3. There is almost always, no need for duplicated code.

  4. Strive to be concise, write readable code with code style in mind.

  5. Dense or complicated code is documented. Teach it to yourself.

  6. Exceptions are handled and communicated properly (catch block, throw exception, descriptive logs)

  7. Justify if a class/method is as many LOC (lines of code) as it needs to be.

  8. Gauge the validity of your types, use dynamic/complex types as needed.

  9. Scope of access should be as restrictive as possible.

  10. Follow OOP, break big problems into smaller, simpler ones. Design methods/classes with this in mind.

You are the last line of defense.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gibberle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 1:38am