PwQt / magic-items-2

This module for Foundry VTT and specific for the DnD5e system, adds the ability to create magical items with spells or feats that belong to the item itself, such as staffs or magic wands, which will be automatically inherited from the character who owns the item.
https://github.com/PwQt/magic-items-2
MIT License
18 stars 7 forks source link

Tidy 5e Sheet issue - item changes cause scroll reset on Details Tab #40

Closed kgar closed 8 months ago

kgar commented 8 months ago

Module Version: v1.4.5

Describe the bug When making changes to an item with the "Tidy 5e Item Sheet" option selected, if the sheet is scrolled down when the change occurs, the scroll resets to the top.

image

image

To Reproduce Steps to reproduce the behavior:

  1. Open an item with "Tidy 5e Item Sheet" selected
  2. Go to the "Details" tab
  3. Make enough changes so that the tab has a scrollbar
  4. Scroll down and make another change
  5. Note that the scrollbar resets to the top

Expected behavior The scroll should remain where it was before making a change to the sheet data. This would make it behave like the default sheets.

Foundry Version: 11.315

Game System: dnd5e

Additional context I have a PR for this, to save you some time, if you are interested in a fix. I am the author of the Tidy 5e Sheet rewrite, but I am reporting this for the original Tidy 5e Sheet module.

PwQt commented 8 months ago

Merged, released in 1.4.6