search

PwQt / magic-items-2

This module for Foundry VTT and specific for the DnD5e system, adds the ability to create magical items with spells or feats that belong to the item itself, such as staffs or magic wands, which will be automatically inherited from the character who owns the item.
https://github.com/PwQt/magic-items-2
MIT License
18 stars 7 forks source link

[FEATURE] Automated Animations Integration #57

Closed Kharmans closed 6 months ago

Kharmans commented 7 months ago

Animations configured with Automated Animations don't work when use a Feature from a item equipped. There's no error on console.

PwQt commented 7 months ago

That's an AA module compatiblity issue - will try to do an integration for it, but it might be merged later looking at the module state

PwQt commented 7 months ago

@Kharmans do you have an example of a feature having an animation?

Kharmans commented 7 months ago

Yeah. I did various but I will paste one of then.

The first one, Zapper, is the item. The second, Feixe de Energia, is the feature. The animation are configure on Feixe de Energia with Template, Ray and the animation _jb2a.lightningbolt.wide.blue.

I don't know if this is relevant, but Feixe de Energia is on a compendium.

fvtt-Item-zapper-YlK3f6GjYN5oJ7FX.json

fvtt-Item-feixe-de-energia-k8M32ApAmZM37OSz.json

Kharmans commented 6 months ago

Okay, looks like some animations are working. I just configure a animation On Token and it play. The other item that I use has a Template animation. Maybe it's broken only on that or other animations, but On Token is working!

nschoenwald commented 6 months ago

I also ran into this issue and can confirm that Template animations do not work with spells cast from magic items.

PwQt commented 6 months ago

I've checked the code and it is on the Automated Animations side to be "fixed" and by that someone would have to make a PR to it.

Since MI doesn't create a real item, it has to be delivered in some other way.

PwQt commented 6 months ago

I've tested this today, and it should be working.

nschoenwald commented 6 months ago

I can confirm, it does work now with current versions of both modules!

PwQt commented 6 months ago

It's probably fixed when I migrated back to magicitems, I've debugged the animation code, and it was broken for Magic Items 2.

Kharmans commented 5 months ago

It's still not working with animations on templates.