search

PwQt / magic-items-2

This module for Foundry VTT and specific for the DnD5e system, adds the ability to create magical items with spells or feats that belong to the item itself, such as staffs or magic wands, which will be automatically inherited from the character who owns the item.
https://github.com/PwQt/magic-items-2
MIT License
18 stars 7 forks source link

[BUG] AE not Applying #84

Closed Kharmans closed 6 months ago

Kharmans commented 6 months ago

Module Version: v1.7.0

Describe the bug When using a Magic Item with a feature that apply AE, the AE are not applied. I already use the macro and redo the item.

To Reproduce Just configure a Magic Item with a Feature that apply an AE, use the Feature and see the AE not applying.

Expected behavior The effect being applied.

Browser: OperaGX LVL5 (core: 107.0.5045.60)

Foundry Version: v11.315

Game System: D&D5e v3.0.4

Other Relevant Modules: MidiQOL v11.4.11.1 DAE v11.3.14

The itens that I an using: Gancho de Escalada with the feature Escalada Segura. I don't know if this is relevant, but the feature are on a compendium.

fvtt-Item-gancho-de-escalada-Z5fKSVzf4GhRpqQw.json fvtt-Item-escalada-segura-mc91VECtMTaSvjRS.json

p4535992 commented 6 months ago

Maybe this was the reason for this piece of code https://github.com/PwQt/magic-items-2/commit/4163d8fd837f2d6c8998b143ff527149675067e0 ? (didn't test it yet)

PwQt commented 6 months ago

I disabled it because it seemed like it was applying that automatically, but it might've been a plugin doing that for me - will check that later today and reenable it for when the plugin is not present.

PwQt commented 6 months ago

@Kharmans

I've managed to locate what module doubles effect - DFreds convenient effect + MIDI Qol "Apply Convenient Effect" setting is doubling the active effect window, I am currently investigating further

PwQt commented 6 months ago

This should be solved in 1.7.1

Kharmans commented 6 months ago

I update and it still doesn't works.

Kharmans commented 6 months ago

@PwQt, when I have Midi and CE activated, I roll the save of the target and if it fails, the effect are not applied. When I have only Midi activated, the target save are not rolling and this errors are showing on console:

image image

Kharmans commented 6 months ago

Okay... I am very confusing right now. One Magic Item that I just configure applied the effect (and play the animation of Automated Animations). But I just test (again) the other Magic Item that I use and it not applied the effect.

Item that applied the effect: Alfange de Águas de Sentina with Furto Vital feature. fvtt-Item-alfange-de-aguas-de-sentina-7rtsbJDRUxnAf55S.json fvtt-Item-furto-vital-zvCfVncrvZLEJ6mR.json

Item that doesn't applied the effect: Abraço Demoníaco with Olhar do Azakana feature. fvtt-Item-abraco-demoniaco-zYnLwzA4NJq6HazM.json fvtt-Item-olhar-do-azakana-u5jwZQd8R8v16uKA.json

Kharmans commented 6 months ago

Another update: the effect are applied when you roll a damage. If you roll just the save or just applied the effect when the item is rolled, the effect are not applied.