Magic Items 4.0 release - Githubissues

PwQt / magic-items-2

This module for Foundry VTT and specific for the DnD5e system, adds the ability to create magical items with spells or feats that belong to the item itself, such as staffs or magic wands, which will be automatically inherited from the character who owns the item.

https://github.com/PwQt/magic-items-2

MIT License

18 stars 7 forks source link

Magic Items 4.0 release #92

Closed PwQt closed 6 months ago

PwQt commented 6 months ago

The main part seems to be working fine, but still todo:

[x] the spells/feats don't show for some reason on either default/tidy5e sheet

PwQt commented 6 months ago

It looks like the conversion api method is wrong atm.

PwQt commented 6 months ago

[x] No flags are present in the compendium packs

PwQt commented 6 months ago

Should be ready to release - testing now

PwQt commented 6 months ago

[x] Add feat and rolltable flag adjustments for the api method

PwQt commented 6 months ago

This should solve https://github.com/PwQt/magic-items-2/issues/89

p4535992 commented 6 months ago

Just a note to update the module packs:

go to the directory https://github.com/PwQt/magic-items-2/tree/master/src/packs/_source and open the folder with visual code
just replace in all the jsons here the string "magic-items-2" to "magicitems"
jump to the package.json directory
run-script build:db packs the db with the new jsons
run-script build:json unpack the db witht he new jsons
commit and push

PwQt commented 6 months ago

@p4535992 Does that work also with VSCode or do I have to have full vs studio instance?

p4535992 commented 6 months ago

@p4535992 Does that work also with VSCode or do I have to have full vs studio instance?

Sorry i write "visual studio" i mean "visual code" is just some npm commands, you can literally use the windows terminal or powershell and launch the same commands