search

Pwn9 / PwnFilter

PwnFilter is a JAVA Plugin for Bukkit, a multiplayer server API for the game Minecraft. Pwnfilter implements Regular Expressions created in a user defined "rules.txt" as an in-game chat filter to remove profane language, spam and caps, for fun and as an effective command alias creator.
GNU General Public License v3.0
15 stars 25 forks source link

1.9 incompatibility - plugin will not load #16

Closed tmad40blue closed 8 years ago

tmad40blue commented 8 years ago

@ptoal @Pwn9 @minecrafter

Hi, looks like PwnFilter is not loading using Spigot 1.9 - the stacktrace is below. Thanks!

[09:35:21] [Server thread/INFO]: [PwnFilter] Enabling PwnFilter v3.3.1                                                                                                                                                                                                                                                        
[09:35:21] [Server thread/INFO]: [PwnFilter] Now logging to plugins/PwnFilter/pwnfilter.log                                                                                                                                                                                                                                   
[09:35:21] [Server thread/INFO]: [PwnFilter] Vault found. Enabling actions requiring Vault                                                                                                                                                                                                                                    
[09:35:21] [Server thread/ERROR]: Error occurred while enabling PwnFilter v3.3.1 (Is it up to date?)                                                                                                                                                                                                                          
java.lang.NoSuchMethodError: org.bukkit.Bukkit.getOnlinePlayers()[Lorg/bukkit/entity/Player;                                                                                                                                                                                                                                  
        at com.pwn9.PwnFilter.DataCache.start(DataCache.java:92) ~[?:?]                                                                                                                                                                                                                                                       
        at com.pwn9.PwnFilter.PwnFilter.onEnable(PwnFilter.java:130) ~[?:?]                                                                                                                                                                                                                                                   
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:291) ~[spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                                         
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:340) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                            
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:405) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                           
        at org.bukkit.craftbukkit.v1_9_R1.CraftServer.loadPlugin(CraftServer.java:361) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                                
        at org.bukkit.craftbukkit.v1_9_R1.CraftServer.enablePlugins(CraftServer.java:321) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                             
        at net.minecraft.server.v1_9_R1.MinecraftServer.t(MinecraftServer.java:411) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                                   
        at net.minecraft.server.v1_9_R1.MinecraftServer.l(MinecraftServer.java:376) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                                   
        at net.minecraft.server.v1_9_R1.MinecraftServer.a(MinecraftServer.java:331) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                                   
        at net.minecraft.server.v1_9_R1.DedicatedServer.init(DedicatedServer.java:269) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                                
        at net.minecraft.server.v1_9_R1.MinecraftServer.run(MinecraftServer.java:522) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                                 
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
ptoal commented 8 years ago

I will be updating PwnFilter to 1.9 very soon. Perhaps a week or so.

tmad40blue commented 8 years ago

Thank you so much! I will be anxiously awaiting your update, as my entire server model depends on it (I run a major family-friendly server).

ptoal commented 8 years ago

Just a heads up that PwnFilter 4.0 (the next release) will only work on Java 8. Java 7 will no longer be supported.

Darunia18 commented 8 years ago

Thank you for updating! I thought this plugin was abandoned. Can't wait to use it again.

johnfriedrich commented 8 years ago

you can manually apply the special source provided by md5. Takes 10 seconds and the plugin works again. Just in case you cannot wait:)

tmad40blue commented 8 years ago

@i9hdkill

Unfortunately, while this does allow the plugin to "load", it does not allow the plugin to function - there appears to be version-specific code in PwnFilter which is preventing it from performing any actions, commands, etc.

I'll be anxiously awaiting the updated version so that I am able to update my server to Spigot 1.9 - this is the final plugin that I am waiting on.

Darunia18 commented 8 years ago

@tmad40blue I updated PwnFilter through the SpecialSource updater and it works great for me! Not only does it load, but the filter works and all the commands work.

itismejoey commented 8 years ago

@Darunia18 Wanna send that to me? ;) BuildTools doesn't like me.

Darunia18 commented 8 years ago

@itismejoey The Spigot jar or the fixed PwnFilter jar? Because Spigot updates multiple times a day, so it'd be best to figure that out yourself.

itismejoey commented 8 years ago

@Darunia18 The PwnFilter. I have another way to get the Spigot.

Darunia18 commented 8 years ago

@itismejoey Fair enough. If you, or anyone else, wants me to send them to fix for PwnFilter, just email me at darunia1818@gmail.com. And just to clarify that this is not a permanent solution. This is just a temporary fix using some Spigot-built tools to change old API functions that were removed to new ones. If there are any issues with it, I cannot help, as I did not change any code myself, and the author of PwnFilter cannot help, as the changes were not written by him.

johnfriedrich commented 8 years ago

To get this plugin working again, you need to change one line of code in the cache.class. That's it. However, to elimate all errors, metrics must be removed. But BuildTools does the job aswell in less than 2 seconds:)

tmad40blue commented 8 years ago

@ptoal

Any news on PwnFilter and when you'll be able to update it to work with Spigot 1.9? Thanks!

elliswin commented 8 years ago

Im on a hosted server and not able to update jar files myself for spigot, we run a server for children with autistic conditions and this plugin is a core feature of our server, can someone send me this fix jar file so I can get it to load at least for now.

thanks in advance can send it to admin@safecraft.co.uk thank you.

itismejoey commented 8 years ago

@elliswin - did you get this yet? I can send it to you once I get home this evening.

2Fast08 commented 8 years ago

https://www.spigotmc.org/resources/pwnfilter.20162/

itismejoey commented 8 years ago

@2fast08- thanks for that, but I already have the fix and I'm not going to use an unofficial release.

2Fast08 commented 8 years ago

That's up to you, however this plugin has had no updates to its source code in 7 months and I am also just as capable as these guys. On Mar 16, 2016 8:57 PM, "Joey Aberle" notifications@github.com wrote:

@2fast08- thanks for that, but I already have the fix and I'm not going to use an unofficial release.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/Pwn9/PwnFilter/issues/16#issuecomment-197649336

bigpresh commented 8 years ago

I use PwnFilter 3.3.1, I used SpecialSauce to get it to run under 1.9, and it mostly seems to work, until I attempt to reload the config/rules with /pfreload which causes a Java exception, which I've reported in #17.

@2Fast08 - kudos for forking for 1.9 support - do you have a GitHub or other repository about to see what you had to change? I want to try your version, but would like to see the code and quite probably build it myself first :)

ptoal commented 8 years ago

Please try the latest 3.9.0 development build: https://ci.sagely.ca/job/PwnFilterDevelopment/

bigpresh commented 8 years ago

I've taken that 3.9.0 dev build for a spin on my test server and, so far, it seems to be working well. I can confirm that the explosion when doing /pfreload no longer happens, and that filtering seems to work as expected.

Thanks for your work on this @ptoal! Greatly appreciate it.

ptoal commented 8 years ago

3.9.0 is now released, available on spigotmc.org and dev.bukkit.org.