search

PyAV-Org / PyAV

Pythonic bindings for FFmpeg's libraries.
https://pyav.basswood-io.com/
BSD 3-Clause "New" or "Revised" License
2.44k stars 359 forks source link

fix: set default color range for VideoReformatter.format() #1458

Closed elxy closed 1 month ago

elxy commented 1 month ago

The behavior of the VideoReformatter.format() is inconsistent with the documentation. According to the documentation, when color_range is None, it should use the color_range of the frame. However, in the function implementation, the default is set to 0.

WyattBlue commented 1 month ago

This reverts the fix to https://github.com/PyAV-Org/PyAV/issues/1378 Why don't we change the documentation instead?

elxy commented 1 month ago

This reverts the fix to #1378 Why don't we change the documentation instead?

Thanks for the reminder. The description of parameters has been updated to match the implementation.