Remove impossible add_stream overload

PyAV-Org / PyAV

Pythonic bindings for FFmpeg's libraries.

https://pyav.basswood-io.com/

BSD 3-Clause "New" or "Revised" License

2.54k stars 366 forks source link

Remove impossible add_stream overload #1614

Closed cdce8p closed 3 weeks ago

cdce8p commented 3 weeks ago

Remove overload which allowed codec_name and template to both have a value / have no value. The code requires that exactly one of the two has a value which is expressed by the other three overloads.

Leftover from #1610.

https://github.com/PyAV-Org/PyAV/blob/f8a07d0b83e2ec1479572542c168b79d7551d817/av/container/output.pyx#L46-L62

WyattBlue commented 3 weeks ago

I think https://github.com/PyAV-Org/PyAV/pull/1615 solves this more completely.

cdce8p commented 3 weeks ago

I think #1615 solves this more completely.

Yes it does. Thanks!