search

PyAr / CDPedia

CDPedia is a project to make the Wikipedia accesable offline
34 stars 15 forks source link

Translate some code, comments and docstrings #382

Closed y-martinez closed 3 years ago

y-martinez commented 3 years ago

This PR partially Close: #184

This PR adds:

y-martinez commented 3 years ago

Hi @facundobatista I made the changes requested, could you review it please :smiley:

facundobatista commented 3 years ago

Hi @facundobatista I made the changes requested, could you review it please smiley

Let me know please when you can check those details I marked, thanks!

y-martinez commented 3 years ago

Hi @facundobatista I made the changes requested, could you review it please smiley

Let me know please when you can check those details I marked, thanks!

Yes I did make the changes @facundobatista but I have a few doubts so I asked you two questions above, can you see them?

facundobatista commented 3 years ago

I answered the questions, but found that lot of details I marked are not fixed.

y-martinez commented 3 years ago

I answered the questions, but found that lot of details I marked are not fixed.

Ohh gosh I was stupid, I forgot that I stashed those changes, and I didn't commit them, I already made the changes