New sign tra - Githubissues

PyAr / pyafipws

Interfases, tools and apps for Argentina's gov't. webservices (soap, com/dll simil-ocx, pdf, dbf, xml, json, etc.) #python

https://github.com/PyAr/pyafipws/wiki/PyAr-PSF-GSoC-2019-Final-Summary

GNU Lesser General Public License v3.0

2 stars 15 forks source link

New sign tra #125

Closed HanslettTheDev closed 1 year ago

HanslettTheDev commented 1 year ago

Summary

This pull request aims to split the sign tra function based on this comment from @reingart. Unit tests will also be added for all the functions to ensure they are properly tested and maintain the standards of the previous general function

Checklist

[x] Classes, Variables, function and methods logic ok
[x] Comments written explaining what the code does

HanslettTheDev commented 1 year ago

The unit testing functions are with me locally. I was working on a bunch of things so I will push all the commits today

HanslettTheDev commented 1 year ago

Manual test evidence of Pytest Test coverage on Python 2.7

HanslettTheDev commented 1 year ago

Coverage Report for both Python 2.7 and 3+

htmlcov-python3+.zip htmlcov-python27.zip

reingart commented 1 year ago

Thanks for the coverage! the python2 zip seems to miss the wsaa.py html, could you re-upload or generate a new report?

HanslettTheDev commented 1 year ago

Reuploaded the test coverage report for python2.7 htmlcov-python27.zip