search

PyBites-Open-Source / eatlocal

This package helps users solve PyBites code challenges on their local machine.
MIT License
20 stars 9 forks source link

Fix #19 by removing getkey package; Install works on Windows #25

Closed pmayd closed 2 years ago

pmayd commented 2 years ago

remove getkey dependency from poetry.lock and pyproject.toml; replace… getkey and quit_display() function instead of a simple console.print(layout) from rich.console package to display the bite; update README with working instructions for windows

pmayd commented 2 years ago

Closes #19

rhelmstedter commented 2 years ago

To clarify my understanding, this eliminates the need for getkey by just printing the display instead of creating a Live loop? Love it.

pmayd commented 2 years ago

To clarify my understanding, this eliminates the need for getkey by just printing the display instead of creating a Live loop? Love it.

Exactly

pmayd commented 2 years ago

I made a little mistake and forgot to delete the quit_display function in my PR so you can delete this deprecated function now, too @rhelmstedter

rhelmstedter commented 2 years ago

Saw that quit_display() was there. It's already gone 👍