Attempt at updated eatlocal for v2 of the platform

PyBites-Open-Source / eatlocal

This package helps users solve PyBites code challenges on their local machine.

MIT License

20 stars 9 forks source link

Attempt at updated eatlocal for v2 of the platform #36

Closed rhelmstedter closed 2 weeks ago

rhelmstedter commented 1 month ago

Updates:

used playwright as discussed
uses the new platform
completely breaks with the old version
installs the chromium browser during the initialization no more need for chrome/chromedriver or even for users to run playwright install
updated readme
no longer pushes code to GitHub when submitting (though I have a function that we can use for a new command if we want)

Still needed:

tests

rhelmstedter commented 1 month ago

I think it is good enough to publish. Test coverage is at 80% (which is waaaaay better that it ever was with v1).

rhelmstedter commented 2 weeks ago

@bbelderbos I addressed everything you pointed out with the exception of the two issues you create. I also added some more tests, markers for the slow end 2 end tests, and updated the readme and version to 1.0.0. Going to merge and publish.

bbelderbos commented 2 weeks ago

Thanks a lot, let me update PyPI ...