search

PyBites-Open-Source / eatlocal

This package helps users solve PyBites code challenges on their local machine.
MIT License
20 stars 9 forks source link

Support google / github login #38

Closed bbelderbos closed 1 week ago

bbelderbos commented 2 weeks ago 
          eatlocal v1 never supported goolge/github login. We gave users who used google/github the option to set a password in their profile/dashboard page (I don't remember which one).

_Originally posted by @rhelmstedter in https://github.com/PyBites-Open-Source/eatlocal/pull/36#discussion_r1829433600_

bbelderbos commented 2 weeks ago

Another option is to allow people to set a password as was the case on v1.

rhelmstedter commented 2 weeks ago

That would be the easier for me lol. But seriously, my concern would be 2FA for google and Github. If the user has to open their phone, or enter a verification code, I'm not sure how to handle that via playwright.

bbelderbos commented 2 weeks ago

Yeah good point, let me put password setting back to v2 then ...

rhelmstedter commented 2 weeks ago

Cool, Then it would be a matter of changing the documentation. "If you logged in with google/github" set a password for your account."

bbelderbos commented 1 week ago

Yep I already have this locally coded so let's go this way, please update the docs as suggested on your download-bite fix branch ...

bbelderbos commented 1 week ago

Done, you can now set a pw:

image