search

PyBites-Open-Source / karmabot

A Python based Slack Chatbot for community interaction
MIT License
73 stars 47 forks source link

Make output of note commands private #112

Open pmayd opened 1 year ago

pmayd commented 1 year ago

We noticed that right now, when you use any of the note commands like @Karmabot note list the output is visible to anyone/others in the same channel (pybob used the command, I could make the screenshot): image

This behavior is not intended, because it both is a privacy violation and increases the overall noise in the channels (something karmabot loves to do).

My proposed solution would be to move these messages into a private chat, so basically turn the output of these commands into DMs for the user.

pogross commented 1 year ago

Easy fix would be to move the note command registration from CHANNEL_BOT_COMMANDS to DM_BOT_COMMANDS.

https://github.com/PyBites-Open-Source/karmabot/blob/70c8a325cd945b684685118f17f1b365d2ca7405/src/karmabot/bot.py#L43-L61

bbelderbos commented 1 year ago

I like that idea, this feature does not seem to have any business being used in channels :) - no?