PyBites-Open-Source / karmabot

A Python based Slack Chatbot for community interaction
MIT License
73 stars 47 forks source link

Welcome message should use ADMINS set in environment and link to them #97

Closed bbelderbos closed 3 years ago

bbelderbos commented 3 years ago

This PR includes the changes of https://github.com/PyBites-Open-Source/karmabot/pull/96/files as I needed them here. I tested it in my env and admins are now used from the corresponding env variable and are properly linked:

image
codecov-commenter commented 3 years ago

Codecov Report

Merging #97 (a06ef62) into develop (0eaeefa) will increase coverage by 1.57%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #97      +/-   ##
===========================================
+ Coverage    54.01%   55.58%   +1.57%     
===========================================
  Files           23       23              
  Lines          735      743       +8     
  Branches        87       89       +2     
===========================================
+ Hits           397      413      +16     
+ Misses         318      312       -6     
+ Partials        20       18       -2     
Impacted Files Coverage Δ
src/karmabot/commands/welcome.py 100.00% <100.00%> (+44.44%) :arrow_up:
src/karmabot/settings.py 89.65% <100.00%> (+15.58%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0eaeefa...a06ef62. Read the comment docs.

bbelderbos commented 3 years ago

Thanks