search

PyBites-Open-Source / pybites-tools

A repo to commit common Python utility scripts and snippets
MIT License
18 stars 8 forks source link

Remove language option #29

Closed rhyspowell closed 2 years ago

rhyspowell commented 2 years ago

Api appears to have removed all but EN as a language choice

bbelderbos commented 2 years ago

@rhyspowell other 2 tests are still failing as well. The payload also changed (origin keyword, see #28).

I think you want to do some mocking instead, pytest-vcr is quite nice.

rhyspowell commented 2 years ago

Will take a look again, it passed on mine and the logs are missing from the tests when I look on the app

rhyspowell commented 2 years ago

Also, as this doesn't have any real business logic, dropping down to a unit test level and using mocks is the wrong thing to do. If we did that we would think the module is fine but we need to be at the integration test level as we are dependant upon a 3rd party.

bbelderbos commented 2 years ago

Yeah good point and distinction. If only mocking we're not testing it end-to-end. Let's just leave it as "real deal" then and fix them. The good thing is that the tests notified us of their API change. Thanks.