search

PyBites-Open-Source / pybitesbooks

30 stars 19 forks source link

Upgrade to the latest Django version #7

Closed pybites closed 4 years ago

pybites commented 4 years ago

Which will break django-registration so either upgrade that to the latest or swap it out for django-allauth.

GorettiRivera commented 4 years ago

@pybites Could you please assign this to me?

bbelderbos commented 4 years ago

Sure, thanks @GorettiRivera Let me know what you do with the registration plugin ...

GorettiRivera commented 4 years ago

@bbelderbos Sure, are you planning to upgrade Django to 3.1 or lower? Because we can upgrade both to 3.1.

Django==3.1 django-registration==3.1

bbelderbos commented 4 years ago

The later/ more recent the better. Btw I am fixing some setup issues, I will link a PR here in a bit.

bbelderbos commented 4 years ago

I ran into these issues: https://github.com/PyBites-Open-Source/pbreadinglist/pull/12 If you pull develop you should have a more smoother setup process :)

bbelderbos commented 4 years ago

And 2 more fixes FYI: https://github.com/PyBites-Open-Source/pbreadinglist/pull/13 https://github.com/PyBites-Open-Source/pbreadinglist/pull/14