Versioning and configuration

PyCOMPLETE / GasFlowHLCalculator

Reconstruct the LHC heat loads from valves, gas flows and temperatures

1 stars 1 forks source link

Versioning and configuration #2

Closed giadarol closed 5 years ago

giadarol commented 5 years ago

At the moment the configuration is handled through the versioning. The topology (which cells etc. is practically blocked. There are hardcoded things like:

from data_S45_details import cell_timber_vars_dict, cell_list, cell_list_pre_EYETS16

    if new_cell:
        cells = cell_list
    else:
        cells = cell_list_pre_EYETS16

giadarol commented 5 years ago

The list of variables is in the folder itself in the files: variable_list_complete.txt and variable_list_special.txt

Could this be inferred by the configuration file?

giadarol commented 5 years ago

Calibration info (for regular cells, not instrumented):

Based on the version, a calibration file (from the repository itself or from an external file) is loaded by config_qbs.py
Data from Run 1 is handled as version -1

giadarol commented 5 years ago

Plan for calibration handling (for regular cells, not instrumented):

I would discontinue the versioning (too complicated with different periods)
I would just provide a link to a calibration folder (repository) where there is a config.py associating the right file to each period.

giadarol commented 5 years ago

We need to have a central configuration file with the paths...

giadarol commented 5 years ago

Versioning taken out today

giadarol commented 5 years ago

The list of variables is in the folder itself in the files: variable_list_complete.txt and variable_list_special.txt

Could this be inferred by the configuration file?

For now we leave it like this... (see #10)

The rest is done (see #10)