search

PyCQA / eradicate

Removes commented-out code from Python files
https://pypi.python.org/pypi/eradicate
206 stars 25 forks source link

add isort action comments to whitelist #33

Closed Cielquan closed 2 years ago

Cielquan commented 2 years ago

fixes #15 (comment)

Cielquan commented 2 years ago

@sobolevn Could you take a look. I directly added all currently available "isort action comments"

sobolevn commented 2 years ago

But, we need to setup GitHub Actions before I can merge this. Do you want to convert travis into GA? 🙂

Cielquan commented 2 years ago

But, we need to setup GitHub Actions before I can merge this. Do you want to convert travis into GA? slightly_smiling_face

Is there a specific reason for transition? Because this project does not see changes often, the relation between time-investment and benefits seem off to me.

But I will take a look at the current config and if it is not that much to do I think I will.

Cielquan commented 2 years ago

@sobolevn Do you plan to make a new release soon? I guess you are waiting for #31 ?

sobolevn commented 2 years ago

Yes!

You can cherry-pick https://github.com/myint/eradicate/pull/31/commits/123381dd514fd95b73b0bb9bc908c3673268eef7 and add tests yourself if you wish.

Then I can make a new release sooner! 🙂

Cielquan commented 2 years ago

I probably will do so in the afternoon when I have time.

sobolevn commented 2 years ago

Thank you ❤️‍🔥