search

PyCQA / eradicate

Removes commented-out code from Python files
https://pypi.python.org/pypi/eradicate
206 stars 25 forks source link

Change travis to gha #34

Closed Cielquan closed 2 years ago

Cielquan commented 2 years ago

Like requested in #33 (comment) here is a translation of the travis config in GHA.

I updated the tested python versions with additional ones and kept the rest as it was.

EDIT: I do not intend to rewrite the config to a proper GHA config. Reason see: https://github.com/myint/eradicate/pull/33#issuecomment-1086034653

Cielquan commented 2 years ago

Removed py3.4 - GHA does not support it anymore Removed py3.5 - ModuleNotFoundError used in test_eradicate.py was added in py3.6

Cielquan commented 2 years ago

I removed coveralls because:

  1. the old version errored: https://github.com/Cielquan/eradicate/runs/5790972462?check_suite_focus=true
  2. the official coveralls GHA action errors too: https://github.com/Cielquan/eradicate/runs/5791028659?check_suite_focus=true
  3. There is no badge or similar on the README indicating the coverage
  4. Coverage is still checked and reported by coveragepy like before
Cielquan commented 2 years ago

Request review by @sobolevn

Cielquan commented 2 years ago

Done

sobolevn commented 2 years ago

I am going to merge this and fix any problems afterwards. Otherwise, we won't be able to test this.

Thanks a lot for your help! 👍

Cielquan commented 2 years ago

There should be none. The workflow ran on my fork and had no issues at the end.