search

PyCQA / eradicate

Removes commented-out code from Python files
https://pypi.python.org/pypi/eradicate
206 stars 25 forks source link

Add integration for pylama #6

Closed aequitas closed 9 years ago

myint commented 9 years ago

Thanks, but I think this would be better as a separate project. Currently, eradicate has no external dependencies, which I prefer.

aequitas commented 9 years ago

I understand. But the dependency would already be fulfilled because you would have pylama installed in order to use the integration. Not having the pylama dependency does not break the normal functionality of this package, as the pylama_eradicate module is only parsed when it is invoked as a pylama linter through the entry_point.

Another solution might be to use 'extras' in order include pylama as a dependency but only if the package is installed with the pylama 'extra' explicitly like: pip install eradicate[pylama].

myint commented 9 years ago

I think I prefer it as a separate project more due to logical dependency rather than what setup.py will install as a dependency. This script will become my responsibility as the owner of this package. Thus, I would feel the need to test it, which means writing test cases for it. I think it would be better if someone that actually uses pylama maintains such a plugin.

(By the way, I think entry_points requires setuptools, whereas this setup.py is currently using plain distutils.)

aequitas commented 9 years ago

I did not pay attention to the setup.py implementation. I will create the plugin it as a separate repository or ask if the pylama dev want to integrate it in his package.